Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8871cd2 authored by Tero Kristo's avatar Tero Kristo Committed by Paul Walmsley
Browse files

ARM: OMAP2+: PRM: remove unnecessary cpu_is_XXX calls from prm_init / exit 



Done in preparation to make PRM its own driver, as the cpu_is_XXX calls are
not available outside mach-omap2 folder.

The init functions are called only from cpu specific init chain, and thus
don't need to double check against cpu type.

The exit calls check against the data provided during init-time registration
and thus don't need cpu check either.

Signed-off-by: default avatarTero Kristo <t-kristo@ti.com>
[paul@pwsan.com: updated to apply]
Signed-off-by: default avatarPaul Walmsley <paul@pwsan.com>
parent 4794208c

arch/arm/mach-omap2/prm2xxx.c

+1 −12
Original line number Diff line number Diff line
@@ -18,9 +18,6 @@ 
#include <linux/io.h>

#include <linux/irq.h>



#include "soc.h"

#include "common.h"

#include "vp.h"

#include "powerdomain.h"

#include "clockdomain.h"

#include "prm2xxx.h"
@@ -201,19 +198,11 @@ static struct prm_ll_data omap2xxx_prm_ll_data = { 


int __init omap2xxx_prm_init(void)

{

	if (!cpu_is_omap24xx())

		return 0;



	return prm_register(&omap2xxx_prm_ll_data);

}



static void __exit omap2xxx_prm_exit(void)

{

	if (!cpu_is_omap24xx())

		return;



	/* Should never happen */

	WARN(prm_unregister(&omap2xxx_prm_ll_data),

	     "%s: prm_ll_data function pointer mismatch\n", __func__);

	prm_unregister(&omap2xxx_prm_ll_data);

}

__exitcall(omap2xxx_prm_exit);

arch/arm/mach-omap2/prm3xxx.c

+1 −9
Original line number Diff line number Diff line
@@ -406,9 +406,6 @@ static struct prm_ll_data omap3xxx_prm_ll_data = { 


int __init omap3xxx_prm_init(void)

{

	if (!cpu_is_omap34xx())

		return 0;



	return prm_register(&omap3xxx_prm_ll_data);

}
@@ -431,11 +428,6 @@ omap_subsys_initcall(omap3xxx_prm_late_init); 


static void __exit omap3xxx_prm_exit(void)

{

	if (!cpu_is_omap34xx())

		return;



	/* Should never happen */

	WARN(prm_unregister(&omap3xxx_prm_ll_data),

	     "%s: prm_ll_data function pointer mismatch\n", __func__);

	prm_unregister(&omap3xxx_prm_ll_data);

}

__exitcall(omap3xxx_prm_exit);

arch/arm/mach-omap2/prm44xx.c

+1 −9
Original line number Diff line number Diff line
@@ -660,9 +660,6 @@ static struct prm_ll_data omap44xx_prm_ll_data = { 


int __init omap44xx_prm_init(void)

{

	if (!cpu_is_omap44xx() && !soc_is_omap54xx() && !soc_is_dra7xx())

		return 0;



	return prm_register(&omap44xx_prm_ll_data);

}
@@ -679,11 +676,6 @@ omap_subsys_initcall(omap44xx_prm_late_init); 


static void __exit omap44xx_prm_exit(void)

{

	if (!cpu_is_omap44xx())

		return;



	/* Should never happen */

	WARN(prm_unregister(&omap44xx_prm_ll_data),

	     "%s: prm_ll_data function pointer mismatch\n", __func__);

	prm_unregister(&omap44xx_prm_ll_data);

}

__exitcall(omap44xx_prm_exit);