Commit d884abbd authored Sep 02, 2019 by Håkon Bugge Committed by Greg Kroah-Hartman Jan 27, 2020

RDMA/cma: Fix false error message

[ Upstream commit a6e4d254c19b541a58caced322111084b27a7788 ]

In addr_handler(), assuming status == 0 and the device already has been
acquired (id_priv->cma_dev != NULL), we get the following incorrect
"error" message:

RDMA CM: ADDR_ERROR: failed to resolve IP. status 0

Fixes: 498683c6 ("IB/cma: Add debug messages to error flows")
Link: https://lore.kernel.org/r/20190902092731.1055757-1-haakon.bugge@oracle.com


Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent c0469da2

drivers/infiniband/core/cma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2889,7 +2889,7 @@ static void addr_handler(int status, struct sockaddr *src_addr,
		if (status)
		pr_debug_ratelimited("RDMA CM: ADDR_ERROR: failed to acquire device. status %d\n",
		status);
		} else {
		} else if (status) {
		pr_debug_ratelimited("RDMA CM: ADDR_ERROR: failed to resolve IP. status %d\n", status);
		}