Commit d7fd2425 authored May 18, 2017 by Jan Kara Committed by Darrick J. Wong May 25, 2017

xfs: Fix off-by-in in loop termination in xfs_find_get_desired_pgoff()



There is an off-by-one error in loop termination conditions in
xfs_find_get_desired_pgoff() since 'end' may index a page beyond end of
desired range if 'endoff' is page aligned. It doesn't have any visible
effects but still it is good to fix it.

Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

parent 5375023a

fs/xfs/xfs_file.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1043,7 +1043,7 @@ xfs_find_get_desired_pgoff(

		index = startoff >> PAGE_SHIFT;
		endoff = XFS_FSB_TO_B(mp, map->br_startoff + map->br_blockcount);
		end = endoff >> PAGE_SHIFT;
		end = (endoff - 1) >> PAGE_SHIFT;
		do {
		int want;
		unsigned nr_pages;