Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7fadce3 authored by Hiral Patel's avatar Hiral Patel Committed by James Bottomley
Browse files

[SCSI] fnic: Kernel panic due to FIP mode misconfiguration 



If switch configured in FIP and adapter configured in non-fip mode, driver
panics while queueing FIP frame in non-existing fip_frame_queue. Added config
check before queueing FIP frame in misconfiguration case to avoid kernel panic.

Signed-off-by: default avatarHiral Patel <hiralpat@cisco.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent d3c995f1

drivers/scsi/fnic/fnic_fcs.c

+6 −0
Original line number Diff line number Diff line
@@ -603,6 +603,12 @@ static inline int fnic_import_rq_eth_pkt(struct fnic *fnic, struct sk_buff *skb) 
		skb_reset_mac_header(skb);

	}

	if (eh->h_proto == htons(ETH_P_FIP)) {

		if (!(fnic->config.flags & VFCF_FIP_CAPABLE)) {

			printk(KERN_ERR "Dropped FIP frame, as firmware "

					"uses non-FIP mode, Enable FIP "

					"using UCSM\n");

			goto drop;

		}

		skb_queue_tail(&fnic->fip_frame_queue, skb);

		queue_work(fnic_fip_queue, &fnic->fip_frame_work);

		return 1;		/* let caller know packet was used */