Commit d7e546d0 authored Oct 01, 2018 by Dan Carpenter Committed by Greg Kroah-Hartman Nov 24, 2019

ASoC: qdsp6: q6asm-dai: checking NULL vs IS_ERR()



[ Upstream commit 8e9f7265eda9f3a662ca1ca47a69042a7840735b ]

The q6asm_audio_client_alloc() doesn't return NULL, it returns error
pointers.

Fixes: 2a9e92d3 ("ASoC: qdsp6: q6asm: Add q6asm dai driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 27ab8f16

sound/soc/qcom/qdsp6/q6asm-dai.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -319,10 +319,11 @@ static int q6asm_dai_open(struct snd_pcm_substream *substream)
		prtd->audio_client = q6asm_audio_client_alloc(dev,
		(q6asm_cb)event_handler, prtd, stream_id,
		LEGACY_PCM_MODE);
		if (!prtd->audio_client) {
		if (IS_ERR(prtd->audio_client)) {
		pr_info("%s: Could not allocate memory\n", __func__);
		ret = PTR_ERR(prtd->audio_client);
		kfree(prtd);
		return -ENOMEM;
		return ret;
		}

		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)