Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7def204 authored by Paul Gortmaker's avatar Paul Gortmaker Committed by Bjorn Helgaas
Browse files

PCI/PME: Make explicitly non-modular 



This code is not being built as a module by anyone:

  config PCIE_PME
        def_bool y
        depends on PCIEPORTBUS && PM

Remove traces of modularity so that when reading the driver there is no
doubt it is builtin-only.

Also delete the .remove function, since that doesn't seem to have a
sensible use case.  With "normal" endpoint drivers, we have in the past set
the suppress_bind_attrs bit to make it clear that the use of ".remove" in a
builtin driver was deleted, but here for PCI, it seems overkill to jump
through the pcie_port_service_driver and into the struct device_driver in
order to finally try and do something similar with the bind setting.

Note that for non-modular code, module_init() translates to
device_initcall().

Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 61612e6d

drivers/pci/pcie/pme.c

+1 −15
Original line number Diff line number Diff line
@@ -10,7 +10,6 @@ 
 * for more details.

 */



#include <linux/module.h>

#include <linux/pci.h>

#include <linux/kernel.h>

#include <linux/errno.h>
@@ -449,17 +448,6 @@ static int pcie_pme_resume(struct pcie_device *srv) 
	return 0;

}



/**

 * pcie_pme_remove - Prepare PCIe PME service device for removal.

 * @srv - PCIe service device to remove.

 */

static void pcie_pme_remove(struct pcie_device *srv)

{

	pcie_pme_suspend(srv);

	free_irq(srv->irq, srv);

	kfree(get_service_data(srv));

}



static struct pcie_port_service_driver pcie_pme_driver = {

	.name		= "pcie_pme",

	.port_type	= PCI_EXP_TYPE_ROOT_PORT,
@@ -468,7 +456,6 @@ static struct pcie_port_service_driver pcie_pme_driver = { 
	.probe		= pcie_pme_probe,

	.suspend	= pcie_pme_suspend,

	.resume		= pcie_pme_resume,

	.remove		= pcie_pme_remove,

};



/**
@@ -478,5 +465,4 @@ static int __init pcie_pme_service_init(void) 
{

	return pcie_port_service_register(&pcie_pme_driver);

}



module_init(pcie_pme_service_init);
 
device_initcall(pcie_pme_service_init);