Commit d7cdac6d authored Jul 15, 2019 by Taehee Yoo Committed by Greg Kroah-Hartman Jul 28, 2019

caif-hsi: fix possible deadlock in cfhsi_exit_module()



[ Upstream commit fdd258d49e88a9e0b49ef04a506a796f1c768a8e ]

cfhsi_exit_module() calls unregister_netdev() under rtnl_lock().
but unregister_netdev() internally calls rtnl_lock().
So deadlock would occur.

Fixes: c4125400 ("caif-hsi: Add rtnl support")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8fb37be1

drivers/net/caif/caif_hsi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1455,7 +1455,7 @@ static void __exit cfhsi_exit_module(void)
		rtnl_lock();
		list_for_each_safe(list_node, n, &cfhsi_list) {
		cfhsi = list_entry(list_node, struct cfhsi, list);
		unregister_netdev(cfhsi->ndev);
		unregister_netdevice(cfhsi->ndev);
		}
		rtnl_unlock();
		}