Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7b164f4 authored by Tianjia Zhang's avatar Tianjia Zhang Committed by Greg Kroah-Hartman
Browse files

crypto: mediatek - Fix wrong return value in mtk_desc_ring_alloc() 



[ Upstream commit 8cbde6c6a6d2b1599ff90f932304aab7e32fce89 ]

In case of memory allocation failure, a negative error code should
be returned.

Fixes: 785e5c61 ("crypto: mediatek - Add crypto driver support for some MediaTek chips")
Cc: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: default avatarTianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b0112ece

drivers/crypto/mediatek/mtk-platform.c

+2 −2
Original line number Diff line number Diff line
@@ -446,7 +446,7 @@ static void mtk_desc_dma_free(struct mtk_cryp *cryp) 
static int mtk_desc_ring_alloc(struct mtk_cryp *cryp)

{

	struct mtk_ring **ring = cryp->ring;

	int i, err = ENOMEM;

	int i;



	for (i = 0; i < MTK_RING_MAX; i++) {

		ring[i] = kzalloc(sizeof(**ring), GFP_KERNEL);
@@ -480,7 +480,7 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp) 
				  ring[i]->cmd_base, ring[i]->cmd_dma);

		kfree(ring[i]);

	}

	return err;

	return -ENOMEM;

}



static int mtk_crypto_probe(struct platform_device *pdev)