Commit d7625f9f authored Feb 20, 2018 by Sven Eckelmann Committed by Simon Wunderlich Feb 27, 2018

batman-adv: Avoid relation operator comparison with bool



commit 785ea114 ("batman-adv: Distributed ARP Table - create DHT helper
functions") introduced a return check of batadv_compare_eth which uses a
boolean return value since commit 16af73458aca ("batman-adv: main,
batadv_compare_eth return bool"). A relational (<, >, <= or >=) operator
is not the right one for such a check.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Acked-by: Antonio Quartulli <a@unstable.cc>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>

parent 84d0a394

net/batman-adv/distributed-arp-table.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -495,7 +495,7 @@ static bool batadv_is_orig_node_eligible(struct batadv_dat_candidate *res,
		* the one with the lowest address
		*/
		if (tmp_max == max && max_orig_node &&
		batadv_compare_eth(candidate->orig, max_orig_node->orig) > 0)
		batadv_compare_eth(candidate->orig, max_orig_node->orig))
		goto out;

		ret = true;