Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d746cb55 authored by Vincent Bernat's avatar Vincent Bernat Committed by Greg Kroah-Hartman
Browse files

staging: visorchipset: fix sparse warnings about static declaration 



Some functions were prototyped as static but the actual definition
wasn't. While this is valid (the function is static because the two
declarations don't conflict and the first one is static), this makes
sparse unhappy and cause confusion of normal people too.

Signed-off-by: default avatarVincent Bernat <vincent@bernat.im>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1496125e

drivers/staging/unisys/visorchipset/visorchipset_main.c

+13 −9
Original line number Diff line number Diff line
@@ -351,7 +351,8 @@ static void controlvm_respond_physdev_changestate(CONTROLVM_MESSAGE_HEADER * 
						  msgHdr, int response,

						  ULTRA_SEGMENT_STATE state);



ssize_t toolaction_show(struct device *dev, struct device_attribute *attr,

static ssize_t toolaction_show(struct device *dev,

			       struct device_attribute *attr,

			       char *buf)

{

	u8 toolAction;
@@ -362,7 +363,8 @@ ssize_t toolaction_show(struct device *dev, struct device_attribute *attr, 
	return scnprintf(buf, PAGE_SIZE, "%u\n", toolAction);

}



ssize_t toolaction_store(struct device *dev, struct device_attribute *attr,

static ssize_t toolaction_store(struct device *dev,

				struct device_attribute *attr,

				const char *buf, size_t count)

{

	u8 toolAction;
@@ -381,7 +383,8 @@ ssize_t toolaction_store(struct device *dev, struct device_attribute *attr, 
		return count;

}



ssize_t boottotool_show(struct device *dev, struct device_attribute *attr,

static ssize_t boottotool_show(struct device *dev,

			       struct device_attribute *attr,

			       char *buf)

{

	ULTRA_EFI_SPAR_INDICATION efiSparIndication;
@@ -394,7 +397,8 @@ ssize_t boottotool_show(struct device *dev, struct device_attribute *attr, 
			efiSparIndication.BootToTool);

}



ssize_t boottotool_store(struct device *dev, struct device_attribute *attr,

static ssize_t boottotool_store(struct device *dev,

				struct device_attribute *attr,

				const char *buf, size_t count)

{

	int val, ret;
@@ -1897,7 +1901,7 @@ handle_command(CONTROLVM_MESSAGE inmsg, HOSTADDRESS channel_addr) 
	return TRUE;

}



HOSTADDRESS controlvm_get_channel_address(void)

static HOSTADDRESS controlvm_get_channel_address(void)

{

	u64 addr = 0;

	u32 size = 0;