Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d740f452 authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Samuel Ortiz
Browse files

mfd: twl4030: Cleanup interrupt handling 



irq_desc checking in a function which is called with that irq
descriptor locked, is pointless. Equally pointless as the irq desc
check in the interrupt service routine. The driver sets those lines
up, so that cant go away magically.

Remove the open coded handler magic and use the proper accessor.

No need to fiddle with irq_desc in the type setting function. The
original value is in irq_data and the core code stores the new setting
when the return value is 0.

This driver needs to be converted to threaded interrupts and buslock.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent 9d8fd10a

drivers/mfd/twl4030-irq.c

+8 −38
Original line number Diff line number Diff line
@@ -320,24 +320,8 @@ static int twl4030_irq_thread(void *data) 
		for (module_irq = twl4030_irq_base;

				pih_isr;

				pih_isr >>= 1, module_irq++) {

			if (pih_isr & 0x1) {

				struct irq_desc *d = irq_to_desc(module_irq);



				if (!d) {

					pr_err("twl4030: Invalid SIH IRQ: %d\n",

					       module_irq);

					return -EINVAL;

				}



				/* These can't be masked ... always warn

				 * if we get any surprises.

				 */

				if (d->status & IRQ_DISABLED)

					note_interrupt(module_irq, d,

							IRQ_NONE);

				else

					d->handle_irq(module_irq, d);

			}

			if (pih_isr & 0x1)

				generic_handle_irq(module_irq);

		}

		local_irq_enable();
@@ -560,24 +544,18 @@ static void twl4030_sih_do_edge(struct work_struct *work) 
	/* Modify only the bits we know must change */

	while (edge_change) {

		int		i = fls(edge_change) - 1;

		struct irq_desc	*d = irq_to_desc(i + agent->irq_base);

		struct irq_data	*idata = irq_get_irq_data(i + agent->irq_base);

		int		byte = 1 + (i >> 2);

		int		off = (i & 0x3) * 2;



		if (!d) {

			pr_err("twl4030: Invalid IRQ: %d\n",

			       i + agent->irq_base);

			return;

		}

		unsigned int	type;



		bytes[byte] &= ~(0x03 << off);



		raw_spin_lock_irq(&d->lock);

		if (d->status & IRQ_TYPE_EDGE_RISING)

		type = irqd_get_trigger_type(idata);

		if (type & IRQ_TYPE_EDGE_RISING)

			bytes[byte] |= BIT(off + 1);

		if (d->status & IRQ_TYPE_EDGE_FALLING)

		if (type & IRQ_TYPE_EDGE_FALLING)

			bytes[byte] |= BIT(off + 0);

		raw_spin_unlock_irq(&d->lock);



		edge_change &= ~BIT(i);

	}
@@ -626,21 +604,13 @@ static void twl4030_sih_unmask(struct irq_data *data) 
static int twl4030_sih_set_type(struct irq_data *data, unsigned trigger)

{

	struct sih_agent *sih = irq_data_get_irq_chip_data(data);

	struct irq_desc *desc = irq_to_desc(data->irq);

	unsigned long flags;



	if (!desc) {

		pr_err("twl4030: Invalid IRQ: %d\n", data->irq);

		return -EINVAL;

	}



	if (trigger & ~(IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))

		return -EINVAL;



	spin_lock_irqsave(&sih_agent_lock, flags);

	if ((desc->status & IRQ_TYPE_SENSE_MASK) != trigger) {

		desc->status &= ~IRQ_TYPE_SENSE_MASK;

		desc->status |= trigger;

	if (irqd_get_trigger_type(data) != trigger) {

		sih->edge_change |= BIT(data->irq - sih->irq_base);

		queue_work(wq, &sih->edge_work);

	}