Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d7372cb6 authored by Tom Yan's avatar Tom Yan Committed by Tejun Heo
Browse files

libata-scsi: use u8 array to store mode page copy 



ata_mselect_*() would initialize a char array for storing a copy of
the current mode page. However, char could be signed char. In that
case, bytes larger than 127 would be converted to negative number.

For example, 0xff from def_control_mpage[] would become -1. This
prevented ata_mselect_control() from working at all, since when it
did the read-only bits check, there would always be a mismatch.

Signed-off-by: default avatarTom Yan <tom.ty89@gmail.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 29b4817d

drivers/ata/libata-scsi.c

+2 −2
Original line number Diff line number Diff line
@@ -3610,7 +3610,7 @@ static int ata_mselect_caching(struct ata_queued_cmd *qc, 
{

	struct ata_taskfile *tf = &qc->tf;

	struct ata_device *dev = qc->dev;

	char mpage[CACHE_MPAGE_LEN];

	u8 mpage[CACHE_MPAGE_LEN];

	u8 wce;

	int i;
@@ -3666,7 +3666,7 @@ static int ata_mselect_control(struct ata_queued_cmd *qc, 
			       const u8 *buf, int len, u16 *fp)

{

	struct ata_device *dev = qc->dev;

	char mpage[CONTROL_MPAGE_LEN];

	u8 mpage[CONTROL_MPAGE_LEN];

	u8 d_sense;

	int i;