Commit d6dcdea7 authored Jun 07, 2009 by Bartlomiej Zolnierkiewicz

ide: remove superfluous SELECT_MASK() call from do_rw_taskfile()

With ->write_devctl method call (which unmasks drive IRQ) preceding
SELECT_MASK() call there is really no need for the latter.

Moreover with the combination of HPT36x controller and the drive on
the quirk_drives[] list this can result in superfluous enable_irq()
call which in turn will trigger WARN() in __enable_irq().

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

parent f9952bee

drivers/ide/ide-taskfile.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -98,7 +98,6 @@ ide_startstop_t do_rw_taskfile(ide_drive_t drive, struct ide_cmd orig_cmd)
		if ((cmd->tf_flags & IDE_TFLAG_DMA_PIO_FALLBACK) == 0) {
		ide_tf_dump(drive->name, cmd);
		tp_ops->write_devctl(hwif, ATA_DEVCTL_OBS);
		SELECT_MASK(drive, 0);

		if (cmd->ftf_flags & IDE_FTFLAG_OUT_DATA) {
		u8 data[2] = { cmd->tf.data, cmd->hob.data };