Commit d6b41cb0 authored Sep 28, 2014 by Xiubo Li Committed by Mark Brown Sep 28, 2014

regmap: fix possible ZERO_SIZE_PTR pointer dereferencing error.



Since we cannot make sure the 'val_count' will always be none zero
here, and then if it equals to zero, the kmemdup() will return
ZERO_SIZE_PTR, which equals to ((void *)16).

So this patch fix this with just doing the zero check before calling
kmemdup().

Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org

parent 5336be84

drivers/base/regmap/regmap.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1659,6 +1659,9 @@ int regmap_bulk_write(struct regmap map, unsigned int reg, const void val,
		} else {
		void *wval;

		if (!val_count)
		return -EINVAL;

		wval = kmemdup(val, val_count * val_bytes, GFP_KERNEL);
		if (!wval) {
		dev_err(map->dev, "Error in memory allocation\n");