Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6124b40 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

uwb: fix device reference leaks 



This subsystem consistently fails to drop the device reference taken by
class_find_device().

Note that some of these lookup functions already take a reference to the
returned data, while others claim no reference is needed (or does not
seem need one).

Fixes: 183b9b59 ("uwb: add the UWB stack (core files)")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent afe4155c

drivers/uwb/lc-rc.c

+13 −3
Original line number Diff line number Diff line
@@ -56,8 +56,11 @@ static struct uwb_rc *uwb_rc_find_by_index(int index) 
	struct uwb_rc *rc = NULL;



	dev = class_find_device(&uwb_rc_class, NULL, &index, uwb_rc_index_match);

	if (dev)

	if (dev) {

		rc = dev_get_drvdata(dev);

		put_device(dev);

	}



	return rc;

}
@@ -467,7 +470,9 @@ struct uwb_rc *__uwb_rc_try_get(struct uwb_rc *target_rc) 
	if (dev) {

		rc = dev_get_drvdata(dev);

		__uwb_rc_get(rc);

		put_device(dev);

	}



	return rc;

}

EXPORT_SYMBOL_GPL(__uwb_rc_try_get);
@@ -520,8 +525,11 @@ struct uwb_rc *uwb_rc_get_by_grandpa(const struct device *grandpa_dev) 


	dev = class_find_device(&uwb_rc_class, NULL, grandpa_dev,

				find_rc_grandpa);

	if (dev)

	if (dev) {

		rc = dev_get_drvdata(dev);

		put_device(dev);

	}



	return rc;

}

EXPORT_SYMBOL_GPL(uwb_rc_get_by_grandpa);
@@ -553,8 +561,10 @@ struct uwb_rc *uwb_rc_get_by_dev(const struct uwb_dev_addr *addr) 
	struct uwb_rc *rc = NULL;



	dev = class_find_device(&uwb_rc_class, NULL, addr, find_rc_dev);

	if (dev)

	if (dev) {

		rc = dev_get_drvdata(dev);

		put_device(dev);

	}



	return rc;

}

drivers/uwb/pal.c

+2 −0
Original line number Diff line number Diff line
@@ -97,6 +97,8 @@ static bool uwb_rc_class_device_exists(struct uwb_rc *target_rc) 


	dev = class_find_device(&uwb_rc_class, NULL, target_rc,	find_rc);



	put_device(dev);



	return (dev != NULL);

}