Commit d5856e1b authored Aug 23, 2019 by Chao Yu Committed by Greg Kroah-Hartman Jan 27, 2020

f2fs: fix wrong error injection path in inc_valid_block_count()



[ Upstream commit 9ea2f0be6ceaebae1518a5f897cff2645830dd95 ]

If FAULT_BLOCK type error injection is on, in inc_valid_block_count()
we may decrease sbi->alloc_valid_block_count percpu stat count
incorrectly, fix it.

Fixes: 36b877af ("f2fs: Keep alloc_valid_block_count in sync")
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent f358f621

fs/f2fs/f2fs.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -1701,7 +1701,7 @@ static inline int inc_valid_block_count(struct f2fs_sb_info *sbi,
		if (time_to_inject(sbi, FAULT_BLOCK)) {
		f2fs_show_injection_info(FAULT_BLOCK);
		release = *count;
		goto enospc;
		goto release_quota;
		}

		/*
		@@ -1741,6 +1741,7 @@ static inline int inc_valid_block_count(struct f2fs_sb_info *sbi,

		enospc:
		percpu_counter_sub(&sbi->alloc_valid_block_count, release);
		release_quota:
		dquot_release_reservation_block(inode, release);
		return -ENOSPC;
		}