Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d57493d6 authored by Alexander Aring's avatar Alexander Aring Committed by David S. Miller
Browse files

net: sched: ife: check on metadata length 



This patch checks if sk buffer is available to dererence ife header. If
not then NULL will returned to signal an malformed ife packet. This
avoids to crashing the kernel from outside.

Signed-off-by: default avatarAlexander Aring <aring@mojatatu.com>
Reviewed-by: default avatarYotam Gigi <yotam.gi@gmail.com>
Acked-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cc74eddd

net/ife/ife.c

+3 −0
Original line number Diff line number Diff line
@@ -69,6 +69,9 @@ void *ife_decode(struct sk_buff *skb, u16 *metalen) 
	int total_pull;

	u16 ifehdrln;



	if (!pskb_may_pull(skb, skb->dev->hard_header_len + IFE_METAHDRLEN))

		return NULL;



	ifehdr = (struct ifeheadr *) (skb->data + skb->dev->hard_header_len);

	ifehdrln = ntohs(ifehdr->metalen);

	total_pull = skb->dev->hard_header_len + ifehdrln;