Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d4296126 authored by Tony Lindgren's avatar Tony Lindgren Committed by Greg Kroah-Hartman
Browse files

phy: cpcap-usb: Fix flakey host idling and enumerating of devices 



commit 049226b9fd7442149dcbcf55f15408f5973cceda upstream.

We must let the USB host idle things properly before we switch to debug
UART mode. Otherwise the USB host may never idle after disconnecting
devices, and that causes the next enumeration to be flakey.

Cc: Jacopo Mondi <jacopo@jmondi.org>
Cc: Marcel Partap <mpartap@gmx.net>
Cc: Merlijn Wajer <merlijn@wizzup.org>
Cc: Michael Scott <hashcode0f@gmail.com>
Cc: NeKit <nekit1000@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>
Acked-by: default avatarPavel Machek <pavel@ucw.cz>
Fixes: 6d6ce40f ("phy: cpcap-usb: Add CPCAP PMIC USB support")
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 99b79d48

drivers/phy/motorola/phy-cpcap-usb.c

+2 −2
Original line number Diff line number Diff line
@@ -281,13 +281,13 @@ static void cpcap_usb_detect(struct work_struct *work) 
		return;

	}



	cpcap_usb_try_musb_mailbox(ddata, MUSB_VBUS_OFF);



	/* Default to debug UART mode */

	error = cpcap_usb_set_uart_mode(ddata);

	if (error)

		goto out_err;



	cpcap_usb_try_musb_mailbox(ddata, MUSB_VBUS_OFF);



	dev_dbg(ddata->dev, "set UART mode\n");



	return;