Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d418ff56 authored by Hans de Goede's avatar Hans de Goede Committed by Tejun Heo
Browse files

libata: Modify quirks for MX100 to limit NCQ_TRIM quirk to MU01 version 



When commit 9c7be59f ("libata: Apply NOLPM quirk to Crucial MX100
512GB SSDs") was added it inherited the ATA_HORKAGE_NO_NCQ_TRIM quirk
from the existing "Crucial_CT*MX100*" entry, but that entry sets model_rev
to "MU01", where as the entry adding the NOLPM quirk sets it to NULL.

This means that after this commit we no apply the NO_NCQ_TRIM quirk to
all "Crucial_CT512MX100*" SSDs even if they have the fixed "MU02"
firmware. This commit splits the "Crucial_CT512MX100*" quirk into 2
quirks, one for the "MU01" firmware and one for all other firmware
versions, so that we once again only apply the NO_NCQ_TRIM quirk to the
"MU01" firmware version.

Fixes: 9c7be59f ("libata: Apply NOLPM quirk to ... MX100 512GB SSDs")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 3bf7b5d6

drivers/ata/libata-core.c

+5 −2
Original line number Diff line number Diff line
@@ -4533,10 +4533,13 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = { 
	/* Crucial BX100 SSD 500GB has broken LPM support */

	{ "CT500BX100SSD1",		NULL,	ATA_HORKAGE_NOLPM },



	/* The 512GB version of the MX100 has both queued TRIM and LPM issues */

	{ "Crucial_CT512MX100*",	NULL,	ATA_HORKAGE_NO_NCQ_TRIM |

	/* 512GB MX100 with MU01 firmware has both queued TRIM and LPM issues */

	{ "Crucial_CT512MX100*",	"MU01",	ATA_HORKAGE_NO_NCQ_TRIM |

						ATA_HORKAGE_ZERO_AFTER_TRIM |

						ATA_HORKAGE_NOLPM, },

	/* 512GB MX100 with newer firmware has only LPM issues */

	{ "Crucial_CT512MX100*",	NULL,	ATA_HORKAGE_ZERO_AFTER_TRIM |

						ATA_HORKAGE_NOLPM, },



	/* 480GB+ M500 SSDs have both queued TRIM and LPM issues */

	{ "Crucial_CT480M500*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |