Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d3c29a5c authored by Eugene Crosser's avatar Eugene Crosser Committed by David S. Miller
Browse files

qeth: remove locks from sysfs _show 



Locking is probably unnecessary in this case, and the rest of the
qeth sysfs code does not use locks in the *_show() functions.
Remove locks from the layer2 *_show() functions in which they where
accidentally introduced.

Signed-off-by: default avatarEugene Crosser <Eugene.Crosser@ru.ibm.com>
Signed-off-by: default avatarUrsula Braun <ursula.braun@de.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c88394e7

drivers/s390/net/qeth_l2_sys.c

+0 −8
Original line number Diff line number Diff line
@@ -23,8 +23,6 @@ static ssize_t qeth_bridge_port_role_state_show(struct device *dev, 
	if (!card)

		return -EINVAL;



	mutex_lock(&card->conf_mutex);



	if (qeth_card_hw_is_reachable(card) &&

					card->options.sbp.supported_funcs)

		rc = qeth_bridgeport_query_ports(card,
@@ -59,8 +57,6 @@ static ssize_t qeth_bridge_port_role_state_show(struct device *dev, 
			rc = sprintf(buf, "%s\n", word);

	}



	mutex_unlock(&card->conf_mutex);



	return rc;

}
@@ -123,12 +119,8 @@ static ssize_t qeth_bridgeport_hostnotification_show(struct device *dev, 
	if (!card)

		return -EINVAL;



	mutex_lock(&card->conf_mutex);



	enabled = card->options.sbp.hostnotification;



	mutex_unlock(&card->conf_mutex);



	return sprintf(buf, "%d\n", enabled);

}