Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d3b40445 authored by Eric Lapuyade's avatar Eric Lapuyade Committed by John W. Linville
Browse files

NFC: Removed addressed shdlc TODOs 



The questions asked in the comments have been answered and addressed.

Signed-off-by: default avatarEric Lapuyade <eric.lapuyade@intel.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent a9a741a7

net/nfc/hci/shdlc.c

+0 −11
Original line number Diff line number Diff line
@@ -340,15 +340,6 @@ static void nfc_shdlc_connect_complete(struct nfc_shdlc *shdlc, int r) 
		shdlc->state = SHDLC_CONNECTED;

	} else {

		shdlc->state = SHDLC_DISCONNECTED;



		/*

		 * TODO: Could it be possible that there are pending

		 * executing commands that are waiting for connect to complete

		 * before they can be carried? As connect is a blocking

		 * operation, it would require that the userspace process can

		 * send commands on the same device from a second thread before

		 * the device is up. I don't think that is possible, is it?

		 */

	}



	shdlc->connect_result = r;
@@ -926,8 +917,6 @@ void nfc_shdlc_free(struct nfc_shdlc *shdlc) 
{

	pr_debug("\n");



	/* TODO: Check that this cannot be called while still in use */



	nfc_hci_unregister_device(shdlc->hdev);

	nfc_hci_free_device(shdlc->hdev);