Commit d3a263a8 authored Jun 24, 2009 by James Bottomley

[SCSI] zalon: fix oops on attach failure



I recently discovered on my zalon that if the attachment fails because
of a bus misconfiguration (I scrapped my HVD array, so the card is now
unterminated) then the system oopses.  The reason is that if
ncr_attach() returns NULL (signalling failure) that NULL is passed by
the goto failed straight into ncr_detach() which oopses.

The fix is just to return -ENODEV in this case.

Cc: Stable Tree <stable@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

parent e3f47cc7

drivers/scsi/zalon.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -134,7 +134,7 @@ zalon_probe(struct parisc_device *dev)

		host = ncr_attach(&zalon7xx_template, unit, &device);
		if (!host)
		goto fail;
		return -ENODEV;

		if (request_irq(dev->irq, ncr53c8xx_intr, IRQF_SHARED, "zalon", host)) {
		dev_printk(KERN_ERR, &dev->dev, "irq problem with %d, detaching\n ",