Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d344b0fb authored by Venkateswararao Jujjuri (JV)'s avatar Venkateswararao Jujjuri (JV) Committed by Eric Van Hensbergen
Browse files

[fs/9p] Initialze cached acls both in cached/uncached mode. 



With create/mkdir/mknod in non cached mode we initialize the inode using
v9fs_get_inode. v9fs_get_inode doesn't initialize the cache inode value
to NULL.  This is causing to trip on BUG_ON in v9fs_get_cached_acl.
Fix is to initialize acls to NULL and not to leave them in ACL_NOT_CACHED
state.

Signed-off-by: default avatarVenkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
Reviewed-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
parent c61fa0d6

fs/9p/acl.c

+6 −4
Original line number Diff line number Diff line
@@ -132,6 +132,10 @@ static int v9fs_set_acl(struct dentry *dentry, int type, struct posix_acl *acl) 
	struct inode *inode = dentry->d_inode;



	set_cached_acl(inode, type, acl);



	if (!acl)

		return 0;



	/* Set a setxattr request to server */

	size = posix_acl_xattr_size(acl->a_count);

	buffer = kmalloc(size, GFP_KERNEL);
@@ -181,9 +185,7 @@ int v9fs_acl_chmod(struct dentry *dentry) 
int v9fs_set_create_acl(struct dentry *dentry,

			struct posix_acl *dpacl, struct posix_acl *pacl)

{

	if (dpacl)

	v9fs_set_acl(dentry, ACL_TYPE_DEFAULT, dpacl);

	if (pacl)

	v9fs_set_acl(dentry, ACL_TYPE_ACCESS, pacl);

	posix_acl_release(dpacl);

	posix_acl_release(pacl);