Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2be66f6 authored by Pablo Neira Ayuso's avatar Pablo Neira Ayuso
Browse files

netfilter: remove comments that predate rcu days 



We cannot block/sleep on nf_iterate because netfilter runs under rcu
read lock these days, where blocking is well-known to be illegal. So
let's remove these old comments.

Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent b250a7fc

net/netfilter/core.c

+0 −7
Original line number Diff line number Diff line
@@ -308,18 +308,11 @@ unsigned int nf_iterate(struct sk_buff *skb, 
{

	unsigned int verdict;



	/*

	 * The caller must not block between calls to this

	 * function because of risk of continuing from deleted element.

	 */

	while (*entryp) {

		if (state->thresh > (*entryp)->ops.priority) {

			*entryp = rcu_dereference((*entryp)->next);

			continue;

		}



		/* Optimization: we don't need to hold module

		   reference here, since function can't sleep. --RR */

repeat:

		verdict = (*entryp)->ops.hook((*entryp)->ops.priv, skb, state);

		if (verdict != NF_ACCEPT) {