Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d2a10ae7 authored by Mark Rustad's avatar Mark Rustad Committed by Jeff Kirsher
Browse files

ixgbe: Remove unused firmware version functions and method 



The firmware version method and functions are not used anywhere, so
remove them all.

Signed-off-by: default avatarMark Rustad <mark.d.rustad@intel.com>
Tested-by: default avatarKrishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 3efa9ed2

drivers/net/ethernet/intel/ixgbe/ixgbe_82598.c

+0 −2
Original line number Diff line number Diff line
@@ -139,8 +139,6 @@ static s32 ixgbe_init_phy_ops_82598(struct ixgbe_hw *hw) 
	case ixgbe_phy_tn:

		phy->ops.setup_link = &ixgbe_setup_phy_link_tnx;

		phy->ops.check_link = &ixgbe_check_phy_link_tnx;

		phy->ops.get_firmware_version =

			     &ixgbe_get_phy_firmware_version_tnx;

		break;

	case ixgbe_phy_nl:

		phy->ops.reset = &ixgbe_reset_phy_nl;

drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c

+0 −2
Original line number Diff line number Diff line
@@ -331,8 +331,6 @@ static s32 ixgbe_init_phy_ops_82599(struct ixgbe_hw *hw) 
	case ixgbe_phy_tn:

		phy->ops.check_link = &ixgbe_check_phy_link_tnx;

		phy->ops.setup_link = &ixgbe_setup_phy_link_tnx;

		phy->ops.get_firmware_version =

			     &ixgbe_get_phy_firmware_version_tnx;

		break;

	default:

		break;

drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c

+0 −34
Original line number Diff line number Diff line
@@ -976,40 +976,6 @@ s32 ixgbe_setup_phy_link_tnx(struct ixgbe_hw *hw) 
	return 0;

}



/**

 *  ixgbe_get_phy_firmware_version_tnx - Gets the PHY Firmware Version

 *  @hw: pointer to hardware structure

 *  @firmware_version: pointer to the PHY Firmware Version

 **/

s32 ixgbe_get_phy_firmware_version_tnx(struct ixgbe_hw *hw,

				       u16 *firmware_version)

{

	s32 status;



	status = hw->phy.ops.read_reg(hw, TNX_FW_REV,

				      MDIO_MMD_VEND1,

				      firmware_version);



	return status;

}



/**

 *  ixgbe_get_phy_firmware_version_generic - Gets the PHY Firmware Version

 *  @hw: pointer to hardware structure

 *  @firmware_version: pointer to the PHY Firmware Version

 **/

s32 ixgbe_get_phy_firmware_version_generic(struct ixgbe_hw *hw,

					   u16 *firmware_version)

{

	s32 status;



	status = hw->phy.ops.read_reg(hw, AQ_FW_REV,

				      MDIO_MMD_VEND1,

				      firmware_version);



	return status;

}



/**

 *  ixgbe_reset_phy_nl - Performs a PHY reset

 *  @hw: pointer to hardware structure

drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h

+0 −4
Original line number Diff line number Diff line
@@ -168,10 +168,6 @@ s32 ixgbe_check_phy_link_tnx(struct ixgbe_hw *hw, 
			     ixgbe_link_speed *speed,

			     bool *link_up);

s32 ixgbe_setup_phy_link_tnx(struct ixgbe_hw *hw);

s32 ixgbe_get_phy_firmware_version_tnx(struct ixgbe_hw *hw,

				       u16 *firmware_version);

s32 ixgbe_get_phy_firmware_version_generic(struct ixgbe_hw *hw,

					   u16 *firmware_version);



s32 ixgbe_reset_phy_nl(struct ixgbe_hw *hw);

s32 ixgbe_set_copper_phy_power(struct ixgbe_hw *hw, bool on);

drivers/net/ethernet/intel/ixgbe/ixgbe_type.h

+0 −1
Original line number Diff line number Diff line
@@ -3404,7 +3404,6 @@ struct ixgbe_phy_operations { 
	s32 (*setup_internal_link)(struct ixgbe_hw *);

	s32 (*setup_link_speed)(struct ixgbe_hw *, ixgbe_link_speed, bool);

	s32 (*check_link)(struct ixgbe_hw *, ixgbe_link_speed *, bool *);

	s32 (*get_firmware_version)(struct ixgbe_hw *, u16 *);

	s32 (*read_i2c_byte)(struct ixgbe_hw *, u8, u8, u8 *);

	s32 (*write_i2c_byte)(struct ixgbe_hw *, u8, u8, u8);

	s32 (*read_i2c_sff8472)(struct ixgbe_hw *, u8 , u8 *);