Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d298ec65 authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman
Browse files

staging: bcm2708_vchiq: fix return value check in vchiq_init_state() 



In case of error, the function kthread_create() returns ERR_PTR() and
never returns NULL. The NULL test in the return value check should be
replaced with IS_ERR().

Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b04451d7

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c

+3 −3
Original line number Diff line number Diff line
@@ -2440,7 +2440,7 @@ vchiq_init_state(VCHIQ_STATE_T *state, VCHIQ_SLOT_ZERO_T *slot_zero, 
		(void *)state,

		threadname);



	if (state->slot_handler_thread == NULL) {

	if (IS_ERR(state->slot_handler_thread)) {

		vchiq_loud_error_header();

		vchiq_loud_error("couldn't create thread %s", threadname);

		vchiq_loud_error_footer();
@@ -2453,7 +2453,7 @@ vchiq_init_state(VCHIQ_STATE_T *state, VCHIQ_SLOT_ZERO_T *slot_zero, 
	state->recycle_thread = kthread_create(&recycle_func,

		(void *)state,

		threadname);

	if (state->recycle_thread == NULL) {

	if (IS_ERR(state->recycle_thread)) {

		vchiq_loud_error_header();

		vchiq_loud_error("couldn't create thread %s", threadname);

		vchiq_loud_error_footer();
@@ -2466,7 +2466,7 @@ vchiq_init_state(VCHIQ_STATE_T *state, VCHIQ_SLOT_ZERO_T *slot_zero, 
	state->sync_thread = kthread_create(&sync_func,

		(void *)state,

		threadname);

	if (state->sync_thread == NULL) {

	if (IS_ERR(state->sync_thread)) {

		vchiq_loud_error_header();

		vchiq_loud_error("couldn't create thread %s", threadname);

		vchiq_loud_error_footer();