Commit d22327a0 authored Nov 10, 2022 by Yang Yingliang Committed by Greg Kroah-Hartman Aug 11, 2023

NTB: ntb_transport: fix possible memory leak while device_register() fails



[ Upstream commit 8623ccbfc55d962e19a3537652803676ad7acb90 ]

If device_register() returns error, the name allocated by
dev_set_name() need be freed. As comment of device_register()
says, it should use put_device() to give up the reference in
the error path. So fix this by calling put_device(), then the
name can be freed in kobject_cleanup(), and client_dev is freed
in ntb_transport_client_release().

Fixes: fce8a7bb ("PCI-Express Non-Transparent Bridge Support")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 7efa1405

drivers/ntb/ntb_transport.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -393,7 +393,7 @@ int ntb_transport_register_client_dev(char *device_name)

		rc = device_register(dev);
		if (rc) {
		kfree(client_dev);
		put_device(dev);
		goto err;
		}