Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0adb51e authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

nfp: add basic multicast filtering 



We currently always pass all multicast traffic through.
Only set L2MC when actually needed.  Since the driver
was not making use of the capability to filter out mcast
frames, some FW projects don't implement it any more.
Don't warn users if capability is not present (like we
do for promisc flag).  The lack of L2MC capability is
assumed to mean all multicast traffic goes through.

Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: default avatarSimon Horman <simon.horman@netronome.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ad521763

drivers/net/ethernet/netronome/nfp/nfp_net_common.c

+5 −2
Original line number Diff line number Diff line
@@ -2850,6 +2850,11 @@ static void nfp_net_set_rx_mode(struct net_device *netdev) 


	new_ctrl = nn->dp.ctrl;



	if (!netdev_mc_empty(netdev) || netdev->flags & IFF_ALLMULTI)

		new_ctrl |= nn->cap & NFP_NET_CFG_CTRL_L2MC;

	else

		new_ctrl &= ~NFP_NET_CFG_CTRL_L2MC;



	if (netdev->flags & IFF_PROMISC) {

		if (nn->cap & NFP_NET_CFG_CTRL_PROMISC)

			new_ctrl |= NFP_NET_CFG_CTRL_PROMISC;
@@ -3787,8 +3792,6 @@ int nfp_net_init(struct nfp_net *nn) 
	/* Allow L2 Broadcast and Multicast through by default, if supported */

	if (nn->cap & NFP_NET_CFG_CTRL_L2BC)

		nn->dp.ctrl |= NFP_NET_CFG_CTRL_L2BC;

	if (nn->cap & NFP_NET_CFG_CTRL_L2MC)

		nn->dp.ctrl |= NFP_NET_CFG_CTRL_L2MC;



	/* Allow IRQ moderation, if supported */

	if (nn->cap & NFP_NET_CFG_CTRL_IRQMOD) {