Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cfea8abf authored by Sergio Paracuellos's avatar Sergio Paracuellos Committed by Greg Kroah-Hartman
Browse files

staging: wlan-ng: get memory from kernel allocators instead of big static buffer 



This patch fix the following sparse warnings in prism2fw.c:
warning: memset with byte count of 120000

Signed-off-by: default avatarSergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 173bf7e3

drivers/staging/wlan-ng/prism2fw.c

+8 −3
Original line number Diff line number Diff line
@@ -124,7 +124,7 @@ struct imgchunk { 


/* Data records */

static unsigned int ns3data;

static struct s3datarec s3data[S3DATA_MAX];

static struct s3datarec *s3data;



/* Plug records */

static unsigned int ns3plug;
@@ -250,7 +250,12 @@ static int prism2_fwapply(const struct ihex_binrec *rfptr, 


	/* Initialize the data structures */

	ns3data = 0;

	memset(s3data, 0, sizeof(s3data));

	s3data = kcalloc(S3DATA_MAX, sizeof(*s3data), GFP_KERNEL);

	if (!s3data) {

		result = -ENOMEM;

		goto out;

	}



	ns3plug = 0;

	memset(s3plug, 0, sizeof(s3plug));

	ns3crc = 0;
@@ -480,7 +485,7 @@ static void free_chunks(struct imgchunk *fchunk, unsigned int *nfchunks) 
static void free_srecs(void)

{

	ns3data = 0;

	memset(s3data, 0, sizeof(s3data));

	kfree(s3data);

	ns3plug = 0;

	memset(s3plug, 0, sizeof(s3plug));

	ns3crc = 0;