Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cfb5966b authored by Li Zefan's avatar Li Zefan Committed by Tejun Heo
Browse files

cpuset: fix RCU lockdep splat in cpuset_print_task_mems_allowed() 



Sasha reported a lockdep warning when OOM was triggered. The reason
is cgroup_name() should be called with rcu_read_lock() held.

Reported-by: default avatarSasha Levin <sasha.levin@oracle.com>
Signed-off-by: default avatarLi Zefan <lizefan@huawei.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent ff794dea

kernel/cpuset.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -2599,6 +2599,7 @@ void cpuset_print_task_mems_allowed(struct task_struct *tsk) 




	struct cgroup *cgrp = task_cs(tsk)->css.cgroup;

	struct cgroup *cgrp = task_cs(tsk)->css.cgroup;





	rcu_read_lock();

	spin_lock(&cpuset_buffer_lock);

	spin_lock(&cpuset_buffer_lock);





	nodelist_scnprintf(cpuset_nodelist, CPUSET_NODELIST_LEN,

	nodelist_scnprintf(cpuset_nodelist, CPUSET_NODELIST_LEN,
@@ -2607,6 +2608,7 @@ void cpuset_print_task_mems_allowed(struct task_struct *tsk) 
	       tsk->comm, cgroup_name(cgrp), cpuset_nodelist);

	       tsk->comm, cgroup_name(cgrp), cpuset_nodelist);





	spin_unlock(&cpuset_buffer_lock);

	spin_unlock(&cpuset_buffer_lock);

	rcu_read_unlock();

}

}





/*

/*