Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf897526 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Al Viro
Browse files

FS-Cache: Add missing initialization of ret in cachefiles_write_page() 



fs/cachefiles/rdwr.c: In function ‘cachefiles_write_page’:
fs/cachefiles/rdwr.c:882: warning: ‘ret’ may be used uninitialized in
this function

If the jump to label "error" is taken, "ret" will indeed be
uninitialized, and random stack data may be printed by the debug code.

Fixes: 102f4d90 ("FS-Cache: Handle a write to the page immediately beyond the EOF marker")
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 8005c49d

fs/cachefiles/rdwr.c

+1 −1
Original line number Diff line number Diff line
@@ -879,7 +879,7 @@ int cachefiles_write_page(struct fscache_storage *op, struct page *page) 
	loff_t pos, eof;

	size_t len;

	void *data;

	int ret;

	int ret = -ENOBUFS;



	ASSERT(op != NULL);

	ASSERT(page != NULL);