Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf6bb58f authored by Pan Bian's avatar Pan Bian Committed by Greg Kroah-Hartman
Browse files

net: dsa: bcm_sf2: put device node before return 



commit cf3c46631e1637582f517a574c77cd6c05793817 upstream.

Put the device node dn before return error code on failure path.

Fixes: 461cd1b0 ("net: dsa: bcm_sf2: Register our slave MDIO bus")
Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Link: https://lore.kernel.org/r/20210121123343.26330-1-bianpan2016@163.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a0b26b9f

drivers/net/dsa/bcm_sf2.c

+6 −2
Original line number Diff line number Diff line
@@ -423,15 +423,19 @@ static int bcm_sf2_mdio_register(struct dsa_switch *ds) 
	/* Find our integrated MDIO bus node */

	dn = of_find_compatible_node(NULL, NULL, "brcm,unimac-mdio");

	priv->master_mii_bus = of_mdio_find_bus(dn);

	if (!priv->master_mii_bus)

	if (!priv->master_mii_bus) {

		of_node_put(dn);

		return -EPROBE_DEFER;

	}



	get_device(&priv->master_mii_bus->dev);

	priv->master_mii_dn = dn;



	priv->slave_mii_bus = devm_mdiobus_alloc(ds->dev);

	if (!priv->slave_mii_bus)

	if (!priv->slave_mii_bus) {

		of_node_put(dn);

		return -ENOMEM;

	}



	priv->slave_mii_bus->priv = priv;

	priv->slave_mii_bus->name = "sf2 slave mii";