Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cec444b7 authored by Ben Dooks's avatar Ben Dooks
Browse files

[ARM] S3C: BUG_ON() if clock has already been registered 



Add a simple check when registering a clock on whether
the clock has already been added to the list.

Any attempt to re-register a clock will cause the
clock list to be come looped and thus produces silent
failures when looking up clocks.

Signed-off-by: default avatarBen Dooks <ben-linux@fluff.org>
parent 93b45885

arch/arm/plat-s3c/clock.c

+3 −0
Original line number Original line Diff line number Diff line
@@ -304,6 +304,9 @@ int s3c24xx_register_clock(struct clk *clk) 




	/* add to the list of available clocks */

	/* add to the list of available clocks */





	/* Quick check to see if this clock has already been registered. */

	BUG_ON(clk->list.prev != clk->list.next);



	spin_lock(&clocks_lock);

	spin_lock(&clocks_lock);

	list_add(&clk->list, &clocks);

	list_add(&clk->list, &clocks);

	spin_unlock(&clocks_lock);

	spin_unlock(&clocks_lock);