Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ce453b3e authored by Michel Thierry's avatar Michel Thierry Committed by Chris Wilson
Browse files

drm/i915: Clear per-engine fault register as early as possible 



From gen6, the hardware tracks address lookup failures and we should
clear those registers upon startup to prevent false positives. However,
this was happening before we have the engines defined (intel_uncore_init())
and the for_each_engine loop was just a nop. The earliest we can call
this is inside intel_engines_init_mmio().

Suggested-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarMichel Thierry <michel.thierry@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20171111004448.12360-1-michel.thierry@intel.com


Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
parent dab91783

drivers/gpu/drm/i915/intel_engine_cs.c

+2 −0
Original line number Diff line number Diff line
@@ -289,6 +289,8 @@ int intel_engines_init_mmio(struct drm_i915_private *dev_priv) 


	device_info->num_rings = hweight32(mask);



	i915_check_and_clear_faults(dev_priv);



	return 0;



cleanup:

drivers/gpu/drm/i915/intel_uncore.c

+0 −2
Original line number Diff line number Diff line
@@ -1420,8 +1420,6 @@ void intel_uncore_init(struct drm_i915_private *dev_priv) 


	iosf_mbi_register_pmic_bus_access_notifier(

		&dev_priv->uncore.pmic_bus_access_nb);



	i915_check_and_clear_faults(dev_priv);

}



void intel_uncore_fini(struct drm_i915_private *dev_priv)