Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cdaf25df authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

smc: some potential use after free bugs 



Say we got really unlucky and these failed on the last iteration, then
it could lead to a use after free bug.

Fixes: cd6851f3 ("smc: remote memory buffers (RMBs)")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarUrsula Braun <ubraun@linux.vnet.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1930b603

net/smc/smc_core.c

+5 −0
Original line number Diff line number Diff line
@@ -532,6 +532,7 @@ int smc_sndbuf_create(struct smc_sock *smc) 
						__GFP_NORETRY);

		if (!sndbuf_desc->cpu_addr) {

			kfree(sndbuf_desc);

			sndbuf_desc = NULL;

			/* if send buffer allocation has failed,

			 * try a smaller one

			 */
@@ -543,6 +544,7 @@ int smc_sndbuf_create(struct smc_sock *smc) 
		if (rc) {

			kfree(sndbuf_desc->cpu_addr);

			kfree(sndbuf_desc);

			sndbuf_desc = NULL;

			continue; /* if mapping failed, try smaller one */

		}

		sndbuf_desc->used = 1;
@@ -596,6 +598,7 @@ int smc_rmb_create(struct smc_sock *smc) 
					     __GFP_NORETRY);

		if (!rmb_desc->cpu_addr) {

			kfree(rmb_desc);

			rmb_desc = NULL;

			/* if RMB allocation has failed,

			 * try a smaller one

			 */
@@ -607,6 +610,7 @@ int smc_rmb_create(struct smc_sock *smc) 
		if (rc) {

			kfree(rmb_desc->cpu_addr);

			kfree(rmb_desc);

			rmb_desc = NULL;

			continue; /* if mapping failed, try smaller one */

		}

		rc = smc_ib_get_memory_region(lgr->lnk[SMC_SINGLE_LINK].roce_pd,
@@ -619,6 +623,7 @@ int smc_rmb_create(struct smc_sock *smc) 
					 DMA_FROM_DEVICE);

			kfree(rmb_desc->cpu_addr);

			kfree(rmb_desc);

			rmb_desc = NULL;

			continue;

		}

		rmb_desc->used = 1;