Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd80735a authored by Tom Rix's avatar Tom Rix Committed by Greg Kroah-Hartman
Browse files

selinux: fix double free 



commit 65de50969a77509452ae590e9449b70a22b923bb upstream.

Clang's static analysis tool reports these double free memory errors.

security/selinux/ss/services.c:2987:4: warning: Attempt to free released memory [unix.Malloc]
                        kfree(bnames[i]);
                        ^~~~~~~~~~~~~~~~
security/selinux/ss/services.c:2990:2: warning: Attempt to free released memory [unix.Malloc]
        kfree(bvalues);
        ^~~~~~~~~~~~~~

So improve the security_get_bools error handling by freeing these variables
and setting their return pointers to NULL and the return len to 0

Cc: stable@vger.kernel.org
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Acked-by: default avatarStephen Smalley <stephen.smalley.work@gmail.com>
Signed-off-by: default avatarPaul Moore <paul@paul-moore.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9a20612e

security/selinux/ss/services.c

+4 −0
Original line number Diff line number Diff line
@@ -2857,8 +2857,12 @@ int security_get_bools(struct selinux_state *state, 
	if (*names) {

		for (i = 0; i < *len; i++)

			kfree((*names)[i]);

		kfree(*names);

	}

	kfree(*values);

	*len = 0;

	*names = NULL;

	*values = NULL;

	goto out;

}