Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd19f7d3 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Mauro Carvalho Chehab
Browse files

[media] as102: fix leaks at failure paths in as102_usb_probe() 



Failure handling is incomplete in as102_usb_probe().
The patch implements proper resource deallocations.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent 42f8f39e

drivers/staging/media/as102/as102_usb_drv.c

+8 −1
Original line number Diff line number Diff line
@@ -401,14 +401,21 @@ static int as102_usb_probe(struct usb_interface *intf, 
	/* request buffer allocation for streaming */

	ret = as102_alloc_usb_stream_buffer(as102_dev);

	if (ret != 0)

		goto failed;

		goto failed_stream;



	/* register dvb layer */

	ret = as102_dvb_register(as102_dev);

	if (ret != 0)

		goto failed_dvb;



	return ret;



failed_dvb:

	as102_free_usb_stream_buffer(as102_dev);

failed_stream:

	usb_deregister_dev(intf, &as102_usb_class_driver);

failed:

	usb_put_dev(as102_dev->bus_adap.usb_dev);

	usb_set_intfdata(intf, NULL);

	kfree(as102_dev);

	return ret;