Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ccfecdfe authored by Michal Simek's avatar Michal Simek Committed by David S. Miller
Browse files

net: emaclite: Report failures in mdio setup 



Be more verbose when any problem happens.

Signed-off-by: default avatarMichal Simek <michal.simek@xilinx.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cafe8902

drivers/net/ethernet/xilinx/xilinx_emaclite.c

+9 −3
Original line number Diff line number Diff line
@@ -852,8 +852,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) 
	/* Don't register the MDIO bus if the phy_node or its parent node

	 * can't be found.

	 */

	if (!np)

	if (!np) {

		dev_err(dev, "Failed to register mdio bus.\n");

		return -ENODEV;

	}



	/* Enable the MDIO bus by asserting the enable bit in MDIO Control

	 * register.
@@ -862,8 +864,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) 
		 XEL_MDIOCTRL_MDIOEN_MASK);



	bus = mdiobus_alloc();

	if (!bus)

	if (!bus) {

		dev_err(dev, "Failed to allocal mdiobus\n");

		return -ENOMEM;

	}



	of_address_to_resource(np, 0, &res);

	snprintf(bus->id, MII_BUS_ID_SIZE, "%.8llx",
@@ -879,8 +883,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) 
	lp->mii_bus = bus;



	rc = of_mdiobus_register(bus, np);

	if (rc)

	if (rc) {

		dev_err(dev, "Failed to register mdio bus.\n");

		goto err_register;

	}



	return 0;