Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc4b8dfc authored by Mithlesh Thukral's avatar Mithlesh Thukral Committed by Greg Kroah-Hartman
Browse files

Staging: sxg: Fix sleep in atomic context warning while loading driver 



Leave a spinlock before calling request_irq(). request_irq() calls kmalloc
which can sleep. This was generating a warning dump while driver is loaded.

Signed-off-by: default avatarLinSysSoft Sahara Team <saharaproj@linsyssoft.com>
Signed-off-by: default avatarMithlesh Thukral <mithlesh@linsyssoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 8d17e6ad

drivers/staging/sxg/sxg.c

+5 −0
Original line number Diff line number Diff line
@@ -322,6 +322,8 @@ int sxg_add_msi_isr(struct adapter_t *adapter) 
	int ret,i;



	if (!adapter->intrregistered) {

		spin_unlock_irqrestore(&sxg_global.driver_lock,

					sxg_global.flags);

		for (i=0; i<adapter->nr_msix_entries; i++) {

			ret = request_irq (adapter->msi_entries[i].vector,

					sxg_isr,
@@ -329,6 +331,8 @@ int sxg_add_msi_isr(struct adapter_t *adapter) 
					adapter->netdev->name,

					adapter->netdev);

			if (ret) {

				spin_lock_irqsave(&sxg_global.driver_lock,

						 sxg_global.flags);

				DBG_ERROR("sxg: MSI-X request_irq (%s) "

					"FAILED [%x]\n", adapter->netdev->name,

					 ret);
@@ -336,6 +340,7 @@ int sxg_add_msi_isr(struct adapter_t *adapter) 
			}

		}

	}

	spin_lock_irqsave(&sxg_global.driver_lock, sxg_global.flags);

	adapter->msi_enabled = TRUE;

	adapter->intrregistered = 1;

	adapter->IntRegistered = TRUE;