Commit cc3b79d4 authored Mar 04, 2019 by Aditya Pakki Committed by Greg Kroah-Hartman Mar 23, 2019

md: Fix failed allocation of md_register_thread



commit e406f12dde1a8375d77ea02d91f313fb1a9c6aec upstream.

mddev->sync_thread can be set to NULL on kzalloc failure downstream.
The patch checks for such a scenario and frees allocated resources.

Committer node:

Added similar fix to raid5.c, as suggested by Guoqing.

Cc: stable@vger.kernel.org # v3.16+
Acked-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 01088750

drivers/md/raid10.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -3959,6 +3959,8 @@ static int raid10_run(struct mddev *mddev)
		set_bit(MD_RECOVERY_RUNNING, &mddev->recovery);
		mddev->sync_thread = md_register_thread(md_do_sync, mddev,
		"reshape");
		if (!mddev->sync_thread)
		goto out_free_conf;
		}

		return 0;

drivers/md/raid5.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -7390,6 +7390,8 @@ static int raid5_run(struct mddev *mddev)
		set_bit(MD_RECOVERY_RUNNING, &mddev->recovery);
		mddev->sync_thread = md_register_thread(md_do_sync, mddev,
		"reshape");
		if (!mddev->sync_thread)
		goto abort;
		}

		/* Ok, everything is just fine now */