Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cbab9012 authored by NeilBrown's avatar NeilBrown Committed by David S. Miller
Browse files

rhashtable: silence RCU warning in rhashtable_test. 



print_ht in rhashtable_test calls rht_dereference() with neither
RCU protection or the mutex.  This triggers an RCU warning.
So take the mutex to silence the warning.

Acked-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarNeilBrown <neilb@suse.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e5ab564c

lib/test_rhashtable.c

+3 −0
Original line number Diff line number Diff line
@@ -501,6 +501,8 @@ static unsigned int __init print_ht(struct rhltable *rhlt) 
	unsigned int i, cnt = 0;



	ht = &rhlt->ht;

	/* Take the mutex to avoid RCU warning */

	mutex_lock(&ht->mutex);

	tbl = rht_dereference(ht->tbl, ht);

	for (i = 0; i < tbl->size; i++) {

		struct rhash_head *pos, *next;
@@ -534,6 +536,7 @@ static unsigned int __init print_ht(struct rhltable *rhlt) 
		}

	}

	printk(KERN_ERR "\n---- ht: ----%s\n-------------\n", buff);

	mutex_unlock(&ht->mutex);



	return cnt;

}