Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cba5957d authored by Anirudh Venkataramanan's avatar Anirudh Venkataramanan Committed by Jeff Kirsher
Browse files

ice: Bug fixes in ethtool code 



1) Return correct size from ice_get_regs_len.
2) Fix incorrect use of ARRAY_SIZE in ice_get_regs.

Fixes: fcea6f3d (ice: Add stats and ethtool support)
Signed-off-by: default avatarAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: default avatarTony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 63bb4e1e

drivers/net/ethernet/intel/ice/ice_ethtool.c

+2 −2
Original line number Diff line number Diff line
@@ -156,7 +156,7 @@ ice_get_drvinfo(struct net_device *netdev, struct ethtool_drvinfo *drvinfo) 


static int ice_get_regs_len(struct net_device __always_unused *netdev)

{

	return ARRAY_SIZE(ice_regs_dump_list);

	return sizeof(ice_regs_dump_list);

}



static void
@@ -170,7 +170,7 @@ ice_get_regs(struct net_device *netdev, struct ethtool_regs *regs, void *p) 


	regs->version = 1;



	for (i = 0; i < ARRAY_SIZE(ice_regs_dump_list) / sizeof(u32); ++i)

	for (i = 0; i < ARRAY_SIZE(ice_regs_dump_list); ++i)

		regs_buf[i] = rd32(hw, ice_regs_dump_list[i]);

}