Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb9eaba4 authored by Nicholas Mc Guire's avatar Nicholas Mc Guire Committed by Wolfram Sang
Browse files

i2c: imx: fix handling of wait_for_completion_timeout result 



wait_for_completion_timeout does not return negative values so
"result" handling here should be simplified to cover the actually
possible cases only.

Signed-off-by: default avatarNicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 387f0de6

drivers/i2c/busses/i2c-imx.c

+4 −4
Original line number Diff line number Diff line
@@ -628,9 +628,9 @@ static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx, 
	result = wait_for_completion_timeout(

				&i2c_imx->dma->cmd_complete,

				msecs_to_jiffies(DMA_TIMEOUT));

	if (result <= 0) {

	if (result == 0) {

		dmaengine_terminate_all(dma->chan_using);

		return result ?: -ETIMEDOUT;

		return -ETIMEDOUT;

	}



	/* Waiting for transfer complete. */
@@ -686,9 +686,9 @@ static int i2c_imx_dma_read(struct imx_i2c_struct *i2c_imx, 
	result = wait_for_completion_timeout(

				&i2c_imx->dma->cmd_complete,

				msecs_to_jiffies(DMA_TIMEOUT));

	if (result <= 0) {

	if (result == 0) {

		dmaengine_terminate_all(dma->chan_using);

		return result ?: -ETIMEDOUT;

		return -ETIMEDOUT;

	}



	/* waiting for transfer complete. */