Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb10c81f authored by Thierry Reding's avatar Thierry Reding
Browse files

drm/tegra: fb: Add error codes to error messages



This helps in determining what errors happened at specifics points in
the initialization sequence.

Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent b88f005e
Loading
Loading
Loading
Loading
+7 −4
Original line number Original line Diff line number Diff line
@@ -233,8 +233,9 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,


	fbdev->fb = tegra_fb_alloc(drm, &cmd, &bo, 1);
	fbdev->fb = tegra_fb_alloc(drm, &cmd, &bo, 1);
	if (IS_ERR(fbdev->fb)) {
	if (IS_ERR(fbdev->fb)) {
		dev_err(drm->dev, "failed to allocate DRM framebuffer\n");
		err = PTR_ERR(fbdev->fb);
		err = PTR_ERR(fbdev->fb);
		dev_err(drm->dev, "failed to allocate DRM framebuffer: %d\n",
			err);
		drm_gem_object_unreference_unlocked(&bo->gem);
		drm_gem_object_unreference_unlocked(&bo->gem);
		goto release;
		goto release;
	}
	}
@@ -319,19 +320,21 @@ static int tegra_fbdev_init(struct tegra_fbdev *fbdev,


	err = drm_fb_helper_init(drm, &fbdev->base, num_crtc, max_connectors);
	err = drm_fb_helper_init(drm, &fbdev->base, num_crtc, max_connectors);
	if (err < 0) {
	if (err < 0) {
		dev_err(drm->dev, "failed to initialize DRM FB helper\n");
		dev_err(drm->dev, "failed to initialize DRM FB helper: %d\n",
			err);
		return err;
		return err;
	}
	}


	err = drm_fb_helper_single_add_all_connectors(&fbdev->base);
	err = drm_fb_helper_single_add_all_connectors(&fbdev->base);
	if (err < 0) {
	if (err < 0) {
		dev_err(drm->dev, "failed to add connectors\n");
		dev_err(drm->dev, "failed to add connectors: %d\n", err);
		goto fini;
		goto fini;
	}
	}


	err = drm_fb_helper_initial_config(&fbdev->base, preferred_bpp);
	err = drm_fb_helper_initial_config(&fbdev->base, preferred_bpp);
	if (err < 0) {
	if (err < 0) {
		dev_err(drm->dev, "failed to set initial configuration\n");
		dev_err(drm->dev, "failed to set initial configuration: %d\n",
			err);
		goto fini;
		goto fini;
	}
	}