Commit caac1d5f authored Feb 13, 2015 by Heba Aamer Committed by Linus Torvalds Feb 13, 2015

checkpatch: improve seq_print->seq_puts suggestion



Improve the format specifier test by removing any %% before looking for
any remaining % format specifier.

Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent f8e58219

scripts/checkpatch.pl

+2 −1

Original line number	Diff line number	Diff line
		@@ -4854,7 +4854,8 @@ sub process {
		# check for seq_printf uses that could be seq_puts
		if ($sline =~ /\bseq_printf\s$."\s$\s;\s*$/) {
		my $fmt = get_quoted_string($line, $rawline);
		if ($fmt ne "" && $fmt !~ /[^\\]\%/) {
		$fmt =~ s/%%//g;
		if ($fmt !~ /%/) {
		if (WARN("PREFER_SEQ_PUTS",
		"Prefer seq_puts to seq_printf\n" . $herecurr) &&
		$fix) {