Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca579c9f authored by Julia Lawall's avatar Julia Lawall Committed by James Bottomley
Browse files

[SCSI] zfcp: remove invalid reference to list iterator variable 

If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure.  Thus this value should not be used after
the end of the iterator.  Replace port->adapter->scsi_host by
adapter->scsi_host.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/

).

Oversight in upsteam commit of v2.6.37
a1ca4831
"[SCSI] zfcp: Move ACL/CFDC code to zfcp_cfdc.c"
which merged the content of zfcp_erp_port_access_changed().

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarSteffen Maier <maier@linux.vnet.ibm.com>
Reviewed-by: default avatarMartin Peschke <mpeschke@linux.vnet.ibm.com>
Cc: <stable@vger.kernel.org> #2.6.37+
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent cb452149

drivers/s390/scsi/zfcp_cfdc.c

+1 −1
Original line number Diff line number Diff line
@@ -293,7 +293,7 @@ void zfcp_cfdc_adapter_access_changed(struct zfcp_adapter *adapter) 
	}

	read_unlock_irqrestore(&adapter->port_list_lock, flags);



	shost_for_each_device(sdev, port->adapter->scsi_host) {

	shost_for_each_device(sdev, adapter->scsi_host) {

		zfcp_sdev = sdev_to_zfcp(sdev);

		status = atomic_read(&zfcp_sdev->status);

		if ((status & ZFCP_STATUS_COMMON_ACCESS_DENIED) ||