Commit ca42fb9e authored Mar 08, 2017 by Dan Carpenter Committed by Samuel Ortiz Apr 02, 2017

NFC: nfcmrvl: double free on error path



The nci_spi_send() function calls kfree_skb(skb) on both error and
success so this extra kfree_skb() is a double free.

Fixes: caf6e49b ("NFC: nfcmrvl: add spi driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>

parent 52fdede5

drivers/nfc/nfcmrvl/spi.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -95,10 +95,9 @@ static int nfcmrvl_spi_nci_send(struct nfcmrvl_private *priv,
		/* Send the SPI packet */
		err = nci_spi_send(drv_data->nci_spi, &drv_data->handshake_completion,
		skb);
		if (err != 0) {
		if (err)
		nfc_err(priv->dev, "spi_send failed %d", err);
		kfree_skb(skb);
		}

		return err;
		}