Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca182551 authored by Konstantin Khlebnikov's avatar Konstantin Khlebnikov Committed by Linus Torvalds
Browse files

kmemleak: clear stale pointers from task stacks

Kmemleak considers any pointers on task stacks as references.  This
patch clears newly allocated and reused vmap stacks.

Link: http://lkml.kernel.org/r/150728990124.744199.8403409836394318684.stgit@buzz


Signed-off-by: default avatarKonstantin Khlebnikov <khlebnikov@yandex-team.ru>
Acked-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 7e866006
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -42,7 +42,7 @@ enum {
#define THREAD_ALIGN	THREAD_SIZE
#endif

#ifdef CONFIG_DEBUG_STACK_USAGE
#if IS_ENABLED(CONFIG_DEBUG_STACK_USAGE) || IS_ENABLED(CONFIG_DEBUG_KMEMLEAK)
# define THREADINFO_GFP		(GFP_KERNEL_ACCOUNT | __GFP_NOTRACK | \
				 __GFP_ZERO)
#else
+4 −0
Original line number Diff line number Diff line
@@ -215,6 +215,10 @@ static unsigned long *alloc_thread_stack_node(struct task_struct *tsk, int node)
		if (!s)
			continue;

#ifdef CONFIG_DEBUG_KMEMLEAK
		/* Clear stale pointers from reused stack. */
		memset(s->addr, 0, THREAD_SIZE);
#endif
		tsk->stack_vm_area = s;
		return s->addr;
	}