Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9cef2c7 authored by Varun Prakash's avatar Varun Prakash Committed by Greg Kroah-Hartman
Browse files

scsi: target: iscsi: cxgbit: fix csk leak 



[ Upstream commit 801df68d617e3cb831f531c99fa6003620e6b343 ]

csk leak can happen if a new TCP connection gets established after
cxgbit_accept_np() returns, to fix this leak free remaining csk in
cxgbit_free_np().

Signed-off-by: default avatarVarun Prakash <varun@chelsio.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent a0134540

drivers/target/iscsi/cxgbit/cxgbit_cm.c

+4 −1
Original line number Diff line number Diff line
@@ -631,8 +631,11 @@ static void cxgbit_send_halfclose(struct cxgbit_sock *csk) 


static void cxgbit_arp_failure_discard(void *handle, struct sk_buff *skb)

{

	struct cxgbit_sock *csk = handle;



	pr_debug("%s cxgbit_device %p\n", __func__, handle);

	kfree_skb(skb);

	cxgbit_put_csk(csk);

}



static void cxgbit_abort_arp_failure(void *handle, struct sk_buff *skb)
@@ -1190,7 +1193,7 @@ cxgbit_pass_accept_rpl(struct cxgbit_sock *csk, struct cpl_pass_accept_req *req) 
	rpl5->opt0 = cpu_to_be64(opt0);

	rpl5->opt2 = cpu_to_be32(opt2);

	set_wr_txq(skb, CPL_PRIORITY_SETUP, csk->ctrlq_idx);

	t4_set_arp_err_handler(skb, NULL, cxgbit_arp_failure_discard);

	t4_set_arp_err_handler(skb, csk, cxgbit_arp_failure_discard);

	cxgbit_l2t_send(csk->com.cdev, skb, csk->l2t);

}