Commit c9862fe6 authored Mar 07, 2017 by Tamara Diaconita Committed by Greg Kroah-Hartman Mar 09, 2017

staging: speakup: kobjects: Delete comparison



Comparison to NULL is not necessary because 'if' statement tests if
'synth' is NULL anyway.

Delete comparison in 'if' structure to fix the checkpath.pl issue :
CHECK: Comparison to NULL could be written 'synth'.

Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6f7c59a8

drivers/staging/speakup/kobjects.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -392,7 +392,7 @@ static ssize_t synth_store(struct kobject kobj, struct kobj_attribute attr,
		len--;
		new_synth_name[len] = '\0';
		spk_strlwr(new_synth_name);
		if ((synth != NULL) && (!strcmp(new_synth_name, synth->name))) {
		if (synth && (!strcmp(new_synth_name, synth->name))) {
		pr_warn("%s already in use\n", new_synth_name);
		} else if (synth_init(new_synth_name) != 0) {
		pr_warn("failed to init synth %s\n", new_synth_name);